-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement chunkObject into queueing #3612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
May 10, 2022
- This should only be used in generation
- The chunk will be used as fallback to set to using bukkit API if WNA fails
dordsor21
added a commit
that referenced
this pull request
May 10, 2022
- Reduces overhead when setting blocks via fallback - Also means blocks will not be accessed via world when they should be access via chunk (#3612)
dordsor21
force-pushed
the
feature/v6/implement-chunk-object
branch
from
May 10, 2022 00:53
17e1245
to
9f3507e
Compare
Citymonstret
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SirYwell
requested changes
May 10, 2022
Bukkit/src/main/java/com/plotsquared/bukkit/queue/BukkitQueueCoordinator.java
Outdated
Show resolved
Hide resolved
NotMyFault
changed the title
Actually implement chunkObject into queueing
Implement chunkObject into queueing
May 10, 2022
NotMyFault
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one
- This should only be used in generation - The chunk will be used as fallback to set to using bukkit API if WNA fails
…oordinator.java Co-authored-by: Hannes Greule <SirYwell@users.noreply.github.com>
dordsor21
force-pushed
the
feature/v6/implement-chunk-object
branch
from
May 11, 2022 12:10
6aa3f7c
to
5266efe
Compare
dordsor21
added a commit
that referenced
this pull request
May 11, 2022
- Reduces overhead when setting blocks via fallback - Also means blocks will not be accessed via world when they should be access via chunk (#3612)
pull bot
pushed a commit
to Craftstuebchen/PlotSquared
that referenced
this pull request
May 12, 2022
pull bot
pushed a commit
to Craftstuebchen/PlotSquared
that referenced
this pull request
May 12, 2022
…lSites#3616) - Reduces overhead when setting blocks via fallback - Also means blocks will not be accessed via world when they should be access via chunk (IntellectualSites#3612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.