Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement chunkObject into queueing #3612

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

dordsor21
Copy link
Member

  • This should only be used in generation
  • The chunk will be used as fallback to set to using bukkit API if WNA fails

@dordsor21 dordsor21 requested a review from a team as a code owner May 10, 2022 00:45
@github-actions github-actions bot added the Feature This PR proposes a new feature label May 10, 2022
dordsor21 added a commit that referenced this pull request May 10, 2022
 - Reduces overhead when setting blocks via fallback
 - Also means blocks will not be accessed via world when they should be access via chunk (#3612)
@dordsor21 dordsor21 force-pushed the feature/v6/implement-chunk-object branch from 17e1245 to 9f3507e Compare May 10, 2022 00:53
Copy link
Member

@Citymonstret Citymonstret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NotMyFault NotMyFault changed the title Actually implement chunkObject into queueing Implement chunkObject into queueing May 10, 2022
@NotMyFault NotMyFault requested a review from SirYwell May 10, 2022 07:03
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

dordsor21 and others added 2 commits May 11, 2022 13:10
 - This should only be used in generation
 - The chunk will be used as fallback to set to using bukkit API if WNA fails
…oordinator.java

Co-authored-by: Hannes Greule <SirYwell@users.noreply.github.com>
@dordsor21 dordsor21 force-pushed the feature/v6/implement-chunk-object branch from 6aa3f7c to 5266efe Compare May 11, 2022 12:10
@dordsor21 dordsor21 merged commit 8b75dec into v6 May 11, 2022
@dordsor21 dordsor21 deleted the feature/v6/implement-chunk-object branch May 11, 2022 12:11
dordsor21 added a commit that referenced this pull request May 11, 2022
- Reduces overhead when setting blocks via fallback
 - Also means blocks will not be accessed via world when they should be access via chunk (#3612)
pull bot pushed a commit to Craftstuebchen/PlotSquared that referenced this pull request May 12, 2022
pull bot pushed a commit to Craftstuebchen/PlotSquared that referenced this pull request May 12, 2022
…lSites#3616)

- Reduces overhead when setting blocks via fallback
 - Also means blocks will not be accessed via world when they should be access via chunk (IntellectualSites#3612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR proposes a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants