Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: including "highestLimit" number #4218

Conversation

RedstoneFuture
Copy link
Member

Overview

The value highestLimit is included to the list as it is described in the Java doc.

Description

Old behavior:

/Core/src/main/java/com/plotsquared/core/command/Visit.java#L353-L354

completions.addAll(
   TabCompletions.completeNumbers(args[2], 10, 999));

grafik

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options
Loading

@RedstoneFuture RedstoneFuture requested a review from a team as a code owner October 28, 2023 19:10
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Oct 28, 2023
@RedstoneFuture RedstoneFuture changed the title Including "highestLimit" number Fix: including "highestLimit" number Oct 28, 2023
@NotMyFault NotMyFault merged commit 95c7f62 into IntellectualSites:main Oct 29, 2023
7 checks passed
SirYwell pushed a commit that referenced this pull request Nov 16, 2023
Including "highestLimit" number
@RedstoneFuture RedstoneFuture deleted the fix/tab-completion-number-list branch November 23, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants