Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce edit-sign flag #4236

Merged
merged 7 commits into from
Nov 26, 2023
Merged

Introduce edit-sign flag #4236

merged 7 commits into from
Nov 26, 2023

Conversation

SirYwell
Copy link
Member

Overview

Fixes #4205

Description

Introduces a flag to allow sign editing separately from the use flag. The use flag is typically used to allow interactions with shops etc, but players should not be able to just edit every sign if the use flag is needed.

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options

@SirYwell SirYwell requested a review from a team as a code owner November 16, 2023 19:27
@github-actions github-actions bot added the Feature This PR proposes a new feature label Nov 16, 2023
@NotMyFault
Copy link
Member

The flag addition should also be documented in https://github.com/IntellectualSites/documentation/tree/main/plotsquared

@dordsor21 dordsor21 merged commit 31ae62b into main Nov 26, 2023
10 checks passed
@dordsor21 dordsor21 deleted the feature/edit-sign-flag branch November 26, 2023 12:36
@Tamikaschu
Copy link
Contributor

Wouldn't it makes sense to add a bypass permission to the flag? Admins who are not added on the plot cannot create signs with text. They all appear empty when placed since the PlayerSignOpenEvent is cancelled.

@Leahcimkrob
Copy link

I'm already looking for that too. You can get around this either way if the admins trust each other for a moment. But it doesn't make sense that an admin can't edit or set the signs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR proposes a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use: #signs flag allows editing signs anywhere
5 participants