New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce base plot count placeholder #4328

Merged

NotMyFault merged 2 commits into main from feature/base-plot-count-placeholder

Feb 12, 2024

Member

SirYwell commented Feb 10, 2024

Overview

Fixes #4314

Description

This introduces a new placeholder %plotsquared_base_plot_count% that gives the number of base plots, i.e. considering connected plots as one.

To keep in sync with %plotsquared_plot_count%, I also added a world-specific variant.

Submitter Checklist

Beta Give feedback

Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.

Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry.

Ensure that the pull request title represents the desired changelog entry.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public fields and methods are annotated with `@since TODO`.

New public fields and methods are annotated with @since TODO.
Options
Successfully updated the issue's project

There was an error updating the issue's project
I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

I read and followed the contribution guidelines.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

SirYwell added 2 commits

February 10, 2024 18:32


          Introduce base plot count placeholder

2f64af7


          add world-specific variant

9de1ea8

SirYwell requested a review from a team as a code owner

February 10, 2024 17:58

github-actions bot added the Feature label

SirYwell mentioned this pull request

Introduce base plot count placeholder IntellectualSites/documentation#66

Merged

PierreSchwang approved these changes

View reviewed changes

Member

PierreSchwang left a comment

LGTM

NotMyFault merged commit a2e3274 into main

8 checks passed

NotMyFault deleted the feature/base-plot-count-placeholder branch

February 12, 2024 17:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment