Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Python3 and fix flake8 errors #4

Merged
merged 1 commit into from
May 23, 2019
Merged

Port to Python3 and fix flake8 errors #4

merged 1 commit into from
May 23, 2019

Conversation

deadbits
Copy link
Contributor

  • Updated the example to use Python3
  • Now accepts arguments at command line for base url, api key, and selector
    • validates base url to ensure its a real domain name
  • Fixed flake8 spacing (e.g., baseurl,apikey,selector -> baseurl, apikey, select
  • Fixed flake8 imports (single import per line)
  • Fixed flake8 commenting (double space after code line, space between # and comment text
  • Standardize use of single / double quote across script
  • Added comment to function describing what it does
  • Added JSON syntax highlighting / pretty-print for output of data
  • Handle HTTP exceptions when requests calls are made
  • Remove extra / unneeded creation of searchurl

@Kleissner Kleissner merged commit 3b0d5f9 into IntelligenceX:master May 23, 2019
@deadbits
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants