Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pointers Atomspace, Spospspace, Snegspace, Arrayspace can be removed #402

Merged
merged 1 commit into from
Oct 10, 2021

Conversation

nbriggs
Copy link
Collaborator

@nbriggs nbriggs commented Oct 10, 2021

These pointers are neither initialized nor referenced anywhere in the code.

These pointers are neither initialized nor referenced anywhere in the code.
Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- are there tools you can use to find things like this?
The Lisp code has remnants from before packages and big atoms.
Is being able to compile Maiko for version 2 a priority.

@nbriggs
Copy link
Collaborator Author

nbriggs commented Oct 10, 2021

The tools I am using didn't find these ones. None of this had conditional compilation flags for version 2, and at least the Spospspace and Snegspace pointers don't make any sense since there isn't host-native-pointer space for smallps...

@nbriggs nbriggs merged commit 75c668f into master Oct 10, 2021
@masinter masinter deleted the 519-remove-unnecessary-smallp-space-pointers branch October 18, 2021 00:23
@masinter
Copy link
Member

fixed Interlisp/medley#519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants