Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Added contributors section to readme.md . #63

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

Kalyanimhala
Copy link
Contributor

@Kalyanimhala Kalyanimhala commented Oct 29, 2023

Fixed #60
Successfully added contributors section to Readme.md file.
@ZwwWayne @Harold-lkk kindly review it and merged the PR. Thank You!!

Successfully added contributors section to Readme.md file.
README.md Outdated Show resolved Hide resolved
Fixed Changes
@Kalyanimhala
Copy link
Contributor Author

@ZwwWayne If you don't mind can I upgrade the project by adding CONTRIBUTING.md file.

Importance of CONTRIBUTING.md:-
A "Contributing.md" file is added to a repository to provide guidelines and
instructions for potential contributors on how to collaborate effectively with the project.
It typically includes information on coding standards, how to submit changes, reporting issues,
and other important details to streamline the contribution process and maintain a healthy
open-source community.

@Kalyanimhala
Copy link
Contributor Author

@ZwwWayne Please review my PR!

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Nov 1, 2023

@ZwwWayne If you don't mind can I upgrade the project by adding CONTRIBUTING.md file.

Importance of CONTRIBUTING.md:- A "Contributing.md" file is added to a repository to provide guidelines and instructions for potential contributors on how to collaborate effectively with the project. It typically includes information on coding standards, how to submit changes, reporting issues, and other important details to streamline the contribution process and maintain a healthy open-source community.

That is great! I suggest we can creat a new PR for the contributing.md. We can put it into docs/en/ and link it in the readme.md

README.md Outdated Show resolved Hide resolved
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Nov 1, 2023

This PR can be merged after fixing the last comments.

Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
@Harold-lkk Harold-lkk merged commit 026eff8 into InternLM:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Adding contributors section to the README.md file.
3 participants