update docs for kvint8 #1026
Merged
update docs for kvint8 #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhyncs
reviewed
Jan 23, 2024
lvhan028
reviewed
Jan 25, 2024
| workspace/triton_models/weights/ \ # Directory to save the quantization parameters | ||
| --num-tp 1 \ # Number of GPUs used for Tensor parallelization, keep it consistent with deploy.py | ||
| --calib-dataset 'ptb' \ | ||
| --calib-samples 128 \ |
There was a problem hiding this comment.
Why remove the comments?
There was a problem hiding this comment.
If one click copy code block (like here)on the readthedocs, then you have to remove the comments to run it. Personally, it's not good for users when they just want to copy and run example code.
There was a problem hiding this comment.
Suggest changing all --quant-policy 4 to --use-kv-int8 True @RunningLeon @lvhan028
lvhan028
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
update docs for kvint8
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist