Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove chat template config in turbomind engine #1161

Merged
merged 16 commits into from
Jun 25, 2024
Merged

remove chat template config in turbomind engine #1161

merged 16 commits into from
Jun 25, 2024

Conversation

irexyc
Copy link
Collaborator

@irexyc irexyc commented Feb 20, 2024

Motivation

Align to torch engine, remove chat_template_mdoel in turbomind engine.

BC-breaking
When using turbomind engine directly, user needs to explicitly specify EngineGenerationConfig and set stop_words

@lvhan028 lvhan028 changed the title Rm tm model remove chat template config in turbomind engine Mar 19, 2024
AllentDan
AllentDan approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesed with

  1. lmdeploy chat turbomind internlm2-chat-7b w/wo --chat-template
  2. pipeline of internlm2-chat-7b w/wo --chat-template
  3. api_server with chat-template

@AllentDan
Copy link
Collaborator

May resolve conflicts

RunningLeon
RunningLeon approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit a06174f into InternLM:main Jun 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllentDan AllentDan AllentDan approved these changes

@RunningLeon RunningLeon RunningLeon approved these changes

@lvhan028 lvhan028 lvhan028 approved these changes

Assignees
No one assigned
Labels
BC-breaking improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irexyc @AllentDan @lvhan028 @RunningLeon