Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while creating the ISRaD_extra object #173

Closed
mguderle opened this issue Feb 25, 2019 · 7 comments
Closed

Error while creating the ISRaD_extra object #173

mguderle opened this issue Feb 25, 2019 · 7 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@mguderle
Copy link
Collaborator

Hi all,

while running the ISRaD.build function, I get the following error when the code tries to create the ISRaD_extra object:

Creating the ISRaD_extra object...
Error in $<-.data.frame(*tmp*, "lyr_dd14c", value = c(-172.4, -330.4, :
replacement has 7101 rows, data has 7029
In addition: Warning message:
In database$layer$lyr_14c - calc_atm14c(database$layer, "lyr_obs_date_y")$atm14C :
longer object length is not a multiple of shorter object length

I used the current version and also updated all packages.

Would be happy for some hints/help.

Best,
Marcus

@mguderle mguderle added the help wanted Extra attention is needed label Feb 25, 2019
@greymonroe
Copy link
Contributor

Hey Marcus,
I was unable to replicate the error. I have the most up to date version. Did this error occur when trying to add a new dataset?

@mguderle
Copy link
Collaborator Author

mguderle commented Feb 26, 2019

Hey Grey,
yes it occurred while adding 1 new datasets, which I attached
Hall_2015_2018.xlsx

Corey combined two datasets (#167). It got a positive QA/QC output.

Corey and Grey, could you please check the template and change it if necessary?

Thanks!

@greymonroe
Copy link
Contributor

greymonroe commented Feb 26, 2019 via email

@coreylawrence
Copy link
Contributor

The problematic dataset is linked in Marcus's post above. I had another look at the file, which passes qa/qc and don't see any immediate red flags. I'm guessing the issue derives from the fill extra function but may be triggered by something in this template. One possibility is the inclusion of two listings in the metadata table, the second of which is not referenced at any other level.

@greymonroe
Copy link
Contributor

I think the issue is because there is already Hall_2015 in the data files. Are these redundant?

@coreylawrence
Copy link
Contributor

Yes, the Hall_2015_2018.xls template is the original Hall_2015 template merged with some additional data reported in a separate publication. The Hall_2015 should be replaced by the new one.

@greymonroe
Copy link
Contributor

greymonroe commented Feb 28, 2019 via email

@jb388 jb388 closed this as completed Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants