-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Dockerfile in ihr-archieve-website #10
Conversation
for #11 |
The command line in the readme misses the port redirection (for example -p 80:80). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a file and tested it...it is only of 47mb
and your image size was 150mb
. here is i hope it will help in futhur development. Thanks
FROM nginx:1.20-alpine
RUN apk update && \
apk upgrade && \
rm -rf /var/cache/apk/*
COPY . /usr/share/nginx/html
EXPOSE 80
CMD ["nginx", "-g", "daemon off;"]
This is new to me...I study about it and soon suggest it. Thankss |
Hii @romain-fontugne. I learn about it and got many new things.. I tried to take a domain but failed as because my IP is not listed in DNS. |
I updated docker file to use certbot and created if you feel it worth we can continue. Thanks. But from my POV. I think we did not require 😅. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is now optimized. Now it is okay from my side. if we not gonna involved in https.
OK, I feel that here it is actually easier to manually deploy the server on a VM, no need for a docker image. Let's close this one. Anyways thanks @Srijan-SS02 and @anmode for looking into this, this is good progress too and I'm learning things too! :) |
@romain-fontugne please review this.