Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Dockerfile in ihr-archieve-website #10

Closed
wants to merge 7 commits into from

Conversation

Srijan-SS02
Copy link

@romain-fontugne please review this.

@Srijan-SS02
Copy link
Author

for #11

@romain-fontugne
Copy link
Member

The command line in the readme misses the port redirection (for example -p 80:80).
And also it lacks letsencrypt to do https. I'm not sure how to add this to the image, and if it will really work?

Copy link

@anmode anmode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a file and tested it...it is only of 47mb and your image size was 150mb. here is i hope it will help in futhur development. Thanks

FROM nginx:1.20-alpine

RUN apk update && \
    apk upgrade && \
    rm -rf /var/cache/apk/*

COPY . /usr/share/nginx/html

EXPOSE 80

CMD ["nginx", "-g", "daemon off;"]

dockerfile Outdated Show resolved Hide resolved
dockerfile Outdated Show resolved Hide resolved
@anmode
Copy link

anmode commented Apr 21, 2023

The command line in the readme misses the port redirection (for example -p 80:80). And also it lacks letsencrypt to do https. I'm not sure how to add this to the image, and if it will really work?

This is new to me...I study about it and soon suggest it. Thankss

@anmode
Copy link

anmode commented Apr 21, 2023

Hii @romain-fontugne. I learn about it and got many new things..
I published my blog on the same and I drafted it- here is the link- https://medium.com/@anmol2002.aa1/lets-encrypt-using-certbot-414708fc36a7
and in the 2nd example i took ihr-archieve-website. Please could you look at it and provide your views.
and I have to add my IP to the domain. to generate the certificate. Idk I may be wrong as this is new to me.

I tried to take a domain but failed as because my IP is not listed in DNS.
Screenshot 2023-04-21 at 4 30 56 PM

@anmode
Copy link

anmode commented Apr 22, 2023

I updated docker file to use certbot and created nginx.conf. and i automate the process through the help of shellscript. So we have https.
here is blog link- https://medium.com/@anmol2002.aa1/lets-encrypt-using-certbot-414708fc36a7

if you feel it worth we can continue. Thanks.

But from my POV. I think we did not require 😅.

Copy link

@anmode anmode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is now optimized. Now it is okay from my side. if we not gonna involved in https.

@romain-fontugne
Copy link
Member

OK, I feel that here it is actually easier to manually deploy the server on a VM, no need for a docker image. Let's close this one. Anyways thanks @Srijan-SS02 and @anmode for looking into this, this is good progress too and I'm learning things too! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants