Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable manual specification of execution units for plutus voting and proposing scripts #744

Merged

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
    Enable manual specification of execution units for plutus voting and proposing scripts
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍. One thing to consider is if we want --vote-execution-units to be optional.
Making it optional would make it retro-compatible and more flexible.

@@ -235,8 +235,8 @@ pTransactionBuildEstimateCmd era _envCli = do
"Filepath of auxiliary script(s)")
<*> many pMetadataFile
<*> pFeatured (shelleyBasedToCardanoEra sbe) (optional pUpdateProposalFile)
<*> pVoteFiles sbe AutoBalance
<*> pProposalFiles sbe AutoBalance
<*> pVoteFiles sbe ManualBalance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an information in the help text about the balancing method used?

Copy link
Contributor Author

@Jimbo4350 Jimbo4350 Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. The balancing method exposes whether or not you need to specify the execution units which is self evident. In the case of transaction build the option is not required (and defaults to ExecutionUnits 0 0) because the balancing is done automatically.

@Jimbo4350
Copy link
Contributor Author

Jimbo4350 commented Apr 30, 2024

Looks good 👍. One thing to consider is if we want --vote-execution-units to be optional. Making it optional would make it retro-compatible and more flexible.

It has to be manually specified in build-estimate. Making it optional would make it impossible to make a valid tx with a plutus voting script.

@Jimbo4350 Jimbo4350 added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@Jimbo4350 Jimbo4350 merged commit 4bdbc16 into main Apr 30, 2024
21 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/enable-manual-execution-unit-balancing-votes-proposals branch April 30, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants