-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable manual specification of execution units for plutus voting and proposing scripts #744
Enable manual specification of execution units for plutus voting and proposing scripts #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍. One thing to consider is if we want --vote-execution-units
to be optional.
Making it optional would make it retro-compatible and more flexible.
@@ -235,8 +235,8 @@ pTransactionBuildEstimateCmd era _envCli = do | |||
"Filepath of auxiliary script(s)") | |||
<*> many pMetadataFile | |||
<*> pFeatured (shelleyBasedToCardanoEra sbe) (optional pUpdateProposalFile) | |||
<*> pVoteFiles sbe AutoBalance | |||
<*> pProposalFiles sbe AutoBalance | |||
<*> pVoteFiles sbe ManualBalance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add an information in the help text about the balancing method used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. The balancing method exposes whether or not you need to specify the execution units which is self evident. In the case of transaction build
the option is not required (and defaults to ExecutionUnits 0 0
) because the balancing is done automatically.
It has to be manually specified in |
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist