Coin Selection Specification: Draft 1 #16
Draft
+978
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/specification-draft-1
branch
from
463368d
to
3d43e27
Compare
jonathanknowles
commented
Mar 23, 2020
jonathanknowles
commented
Mar 23, 2020
jonathanknowles
commented
Mar 23, 2020
jonathanknowles
commented
Mar 23, 2020
jonathanknowles
commented
Mar 23, 2020
jonathanknowles
commented
Mar 23, 2020
jonathanknowles
commented
Mar 23, 2020
The maximum should be 3v, rather than 2v. Fixes #16 (comment)
This change replaces "here" with the more specific "this document", and clarifies that the agnosticism relates to the choice of address format, rather than to the details of such formats. Fixes #16 (comment)
rvl
approved these changes
Mar 25, 2020
jonathanknowles
requested review from
paweljakubas,
Anviking,
piotr-iohk and
KtorZ
KtorZ
reviewed
Mar 25, 2020
KtorZ
reviewed
Mar 25, 2020
KtorZ
reviewed
Mar 25, 2020
KtorZ
reviewed
Mar 25, 2020
KtorZ
reviewed
Mar 25, 2020
KtorZ
reviewed
Mar 25, 2020
KtorZ
reviewed
Mar 25, 2020
KtorZ
reviewed
Mar 25, 2020
KtorZ
reviewed
Mar 25, 2020
jonathanknowles
force-pushed
the
jonathanknowles/specification-draft-1
branch
13 times, most recently
from
dea8f77
to
79122b7
Compare
Explain the motivation behind choosing a UTxO selection whose value is approximately twice the value of the output to which it corresponds.
jonathanknowles
force-pushed
the
jonathanknowles/specification-draft-1
branch
from
79122b7
to
4cf7b13
Compare
jonathanknowles
force-pushed
the
jonathanknowles/specification-draft-1
branch
from
75d9e00
to
3471486
Compare
jonathanknowles
force-pushed
the
jonathanknowles/specification-draft-1
branch
from
edc91a8
to
e93c24a
Compare
jonathanknowles
force-pushed
the
jonathanknowles/specification-draft-1
branch
from
e93c24a
to
01a1faf
Compare
jonathanknowles
force-pushed
the
jonathanknowles/specification-draft-1
branch
from
7247429
to
4a99359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#21
Summary
This PR contains a draft of a specification for the coin selection algorithms used by Cardano Wallet.
The purpose of the specification is to provide an easy-to-understand, human-readable description of these algorithms that doesn't require an understanding of Haskell.
The purpose of this PR is to gain feedback on areas for improvement. Please feel free to leave comments and constructive suggestions!
The document is written in Markdown, and can be read in its rendered form.
Please note that there are several areas not addressed by this specification: