Further proposals improvements. Take 2 #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/further-proposals-improvements
branch
from
f214b6b
to
d1560ae
Compare
aniketd
reviewed
Feb 1, 2024
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs
Outdated
Show resolved
Hide resolved
lehins
force-pushed
the
lehins/further-proposals-improvements
branch
from
d1560ae
to
aa43b80
Compare
…nts` * Emphasize in the name that not only descendants will be removed, but also the govActionIds supplied as arguments * Marked is for testing only, since it is not suitable for deleting roots * Fixed the spelling: descendant is someone who descended from an anscentor
lehins
force-pushed
the
lehins/further-proposals-improvements
branch
from
aa43b80
to
30f7c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to: #4025
One important place where invariant was not verified was when enacted proposals are being removed. With adding the check there we no longer need to bother adding any other checks, as long as other internal functions are not being used for modifying the Proposals
Other changes are minor cleanups and performance improvements
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)