Further improvements to Proposals
#4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
changed the title
Proposals
lehins
force-pushed
the
lehins/further-improvements-to-proposals
branch
from
07d5db8 to
05d73f4
Compare
lehins
force-pushed
the
lehins/further-improvements-to-proposals
branch
from
05d73f4 to
f562788
Compare
* Remove `PrevGovActionIds` in favor of direct usage of `GovRelation` * Abstract common usage pattern in `withGovActionParent` * Add another invariant verification to Proposal's
lehins
force-pushed
the
lehins/further-improvements-to-proposals
branch
from
f562788 to
a29db41
Compare
This rename is useful to avoid misconception that pre-babbage TxOut style will get deprcated. This could not be further from the truth, since it is a more efficient representation and is used by default when encoding simple TxOut. Therefore, there is no reason to call it legacy.
aniketd
approved these changes
Jan 31, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename
PForesttoGovRelationand make it public:PrevGovActionIdsin favor of direct usage ofGovRelationwithGovActionParentRename
legacy_transaction_outputtopre_babbage_transaction_outputin CDDLChecklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)