Proposal deposits in SPO voting stake #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/proposal-deposits-in-spo-voting-stake
branch
2 times, most recently
from
cbc7ebb
to
97d9375
Compare
lehins
force-pushed
the
aniketd/proposal-deposits-in-spo-voting-stake
branch
from
97d9375
to
c77828b
Compare
lehins
reviewed
May 8, 2024
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Examples/PoolLifetime.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/PulsingReward.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/DRepPulser.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/DRepPulser.hs
Outdated
Show resolved
Hide resolved
aniketd
force-pushed
the
aniketd/proposal-deposits-in-spo-voting-stake
branch
from
c77828b
to
21f4b2b
Compare
aniketd
commented
May 8, 2024
aniketd
commented
May 8, 2024
aniketd
commented
May 8, 2024
aniketd
commented
May 8, 2024
lehins
reviewed
May 8, 2024
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/DRepPulser.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
May 8, 2024
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/DRepPulser.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
May 8, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Vars.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
May 8, 2024
lehins
reviewed
May 8, 2024
aniketd
force-pushed
the
aniketd/proposal-deposits-in-spo-voting-stake
branch
from
425a7e7
to
7a877b2
Compare
lehins
reviewed
May 10, 2024
Soupstraw
reviewed
May 13, 2024
Soupstraw
reviewed
May 13, 2024
Soupstraw
reviewed
May 13, 2024
Soupstraw
reviewed
May 13, 2024
* Add individualPoolStakeCoin field to IndividualPoolStake as numerator. * Add pdTotal field to PoolDistr as denominator. * Change calculatePoolDistr' to include the numerator and denominator. * Update computeDRepDistr to include updating PoolDistr numerator and denominator with proposal-deposits. * Update spoAcceptedRatio to calculate in terms of the numerator/ denominator pair instead of Rational.
We reset the newly added fields: individualTotalPoolStake and pdTotalActiveStake, in the ledger state that testCHAINEXample compares with checkTrace, so as to not interfere with the chained ledger states in these tests.
The prop_RATIFY test revealed a bug in the current implementation of spoAcceptedRatio that constructs a `Ratio` out of the numerator and denominator of the PoolDistr. We use the same method of defaulting it to unit if it is zero.
aniketd
force-pushed
the
aniketd/proposal-deposits-in-spo-voting-stake
branch
from
196f4c1
to
00a0970
Compare
aniketd
force-pushed
the
aniketd/proposal-deposits-in-spo-voting-stake
branch
from
9920384
to
0a1cc62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4061
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)