Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node version to 8.12.2 #5893

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

johnalotoski
Copy link
Contributor

Description

  • Bump node version to 8.12.2

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@johnalotoski johnalotoski requested a review from a team as a code owner June 29, 2024 02:12
@johnalotoski johnalotoski force-pushed the jl/node-8.12.2-version-update branch from a5a8e00 to 1674dff Compare June 29, 2024 05:14
@disassembler disassembler added this pull request to the merge queue Jun 29, 2024
Merged via the queue into master with commit 71f8c71 Jun 29, 2024
23 checks passed
@disassembler disassembler deleted the jl/node-8.12.2-version-update branch June 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants