-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory not created automatically for save() method #56
Comments
I am undecisive about this. It seems practical, if the save method creates directories automatically but on the other hand I think it's bad practice, if an Image class messes around in the filesystem. |
Maybe let the choice to the developer with a config option and a default value? |
I think it's bad practice. Use mkdir to create directories (recursively). I want to keep it simple, creating directories automatically may cause confusion. |
Suggestion: Please add a flag in the intervention configuration, so the developer can decide if he want intervention to create directories? |
+1 |
indeed i need this too |
Hello guys, thank you for this amazing library. I am using its integration with Laravel 4 and it works wonderfully.
I encountered an error when trying to save an image to a directory that did not exist. It is not a permission problem, it is just a feature that is missing: create the directory first if it does not exists. Maybe its an easy fix, but I don't feel comfortable enough to modify the library myself...
Hope you guys can take a look into it for a future release.
Thank you!
The text was updated successfully, but these errors were encountered: