Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory not created automatically for save() method #56

Closed
pechitook opened this issue Dec 8, 2013 · 6 comments
Closed

Directory not created automatically for save() method #56

pechitook opened this issue Dec 8, 2013 · 6 comments

Comments

@pechitook
Copy link

Hello guys, thank you for this amazing library. I am using its integration with Laravel 4 and it works wonderfully.

I encountered an error when trying to save an image to a directory that did not exist. It is not a permission problem, it is just a feature that is missing: create the directory first if it does not exists. Maybe its an easy fix, but I don't feel comfortable enough to modify the library myself...

Hope you guys can take a look into it for a future release.

Thank you!

@olivervogel
Copy link
Member

I am undecisive about this. It seems practical, if the save method creates directories automatically but on the other hand I think it's bad practice, if an Image class messes around in the filesystem.

@Fractaliste
Copy link

Maybe let the choice to the developer with a config option and a default value?

@olivervogel
Copy link
Member

I think it's bad practice.

Use mkdir to create directories (recursively).

I want to keep it simple, creating directories automatically may cause confusion.

@martinandersen3d
Copy link

Suggestion: Please add a flag in the intervention configuration, so the developer can decide if he want intervention to create directories?

@websitevirtuoso
Copy link

+1

@DrCod3r
Copy link

DrCod3r commented May 28, 2020

indeed i need this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants