Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CONTRIBUTING.md and BUILDING.md files #174

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

IraSoro
Copy link
Owner

@IraSoro IraSoro commented Nov 3, 2023

Closed #144

I added a CONTRIBUTING.md file in which I described the steps for translation into new languages.
I added the BUILDING.md file. I moved the build information from the README.md file into it.
And edited the README.md file.

@IraSoro IraSoro added this to the v2.3.5 milestone Nov 3, 2023
@IraSoro IraSoro self-assigned this Nov 3, 2023
CONTRIBUTING.md Outdated

### Steps

1. Look for the `/utils/translations` directory to find existing translations. If you don't find the language you wish to translate the application into, proceed to step 2.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe if you didn't find the language you interested in then proceed to step 2

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ок

CONTRIBUTING.md Outdated

### Steps

1. Look for the `/utils/translations` directory to find existing translations. If you don't find the language you wish to translate the application into, proceed to step 2.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/utils/translations looks like an absolute unix path. Maybe ./src/utils/translations?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

CONTRIBUTING.md Outdated

1. Look for the `/utils/translations` directory to find existing translations. If you don't find the language you wish to translate the application into, proceed to step 2.

2. Create a new file for the language by duplicating the `ru.ts` file in the `/translations` directory. Name it using the language code (e.g., `fr.ts` for French translations).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./src/utils/translations/ru.ts

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

CONTRIBUTING.md Outdated

2. Create a new file for the language by duplicating the `ru.ts` file in the `/translations` directory. Name it using the language code (e.g., `fr.ts` for French translations).

3. Translate the content within the file into your desired language.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translate the keys into your language

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

CONTRIBUTING.md Outdated

3. Translate the content within the file into your desired language.

4. In the directory `/utils` open the file `translation.ts`. Import the generated file like this:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import translation file in the ./src/utils/translations.ts

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

CONTRIBUTING.md Outdated
import ru from "./translations/ru";
```

5. Add the language to the `supportedLanguages` variable like this:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the language to the supportedLanguages map like this, to show this language in the app's menu

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

CONTRIBUTING.md Outdated
},
```

7. In the directory `/utils` open the file `datetime.ts`. Add the locale to the `locales` variable like this:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./src/utils/datetime.ts

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

CONTRIBUTING.md Outdated
]);
```

8. Submit a Pull Request with the translated file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but maybe Make a Pull Requests with the translated file?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's do it this way

README.md Outdated
@@ -50,77 +50,8 @@ See the [open issues](https://github.com/IraSoro/peri/issues) and [project](http

### How to build

Install dependencies:
You can find full instruction about the project building in [BUILDING.md](https://github.com/IraSoro/peri/blob/master/BUILDING.md) file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can find the full instruction about the project building in

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@IraSoro IraSoro merged commit 6d39f5b into master Nov 6, 2023
2 checks passed
@IraSoro IraSoro deleted the 144-add-contributing-md branch November 6, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Translation plan
2 participants