Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: editing current period #178

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Conversation

IraSoro
Copy link
Owner

@IraSoro IraSoro commented Nov 12, 2023

Closed #155

The bug is described in the issue. I fixed it. Now if you follow all the steps described in the problem, an alert will appear with a warning. And also the marked days will become as before editing.
image

@IraSoro IraSoro added this to the v2.3.5 milestone Nov 12, 2023
@IraSoro IraSoro self-assigned this Nov 12, 2023
Copy link
Collaborator

@imblowfish imblowfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question. What if user marked one of the days in the previous period by error. Is it still available to remove unnecessary day or these changes persistent and this day marked by error will remain?

src/state/CalculationLogics.ts Outdated Show resolved Hide resolved
src/state/CalculationLogics.ts Outdated Show resolved Hide resolved
src/pages/TabHome.tsx Outdated Show resolved Hide resolved
src/state/CalculationLogics.ts Outdated Show resolved Hide resolved
src/state/CalculationLogics.ts Outdated Show resolved Hide resolved
src/state/CalculationLogics.ts Outdated Show resolved Hide resolved
src/pages/TabHome.tsx Outdated Show resolved Hide resolved
@IraSoro
Copy link
Owner Author

IraSoro commented Nov 13, 2023

If I understood the question correctly, there will be no error. This checks if the dates following today are marked. If yes and the date is not marked today, then there is an error. Previous dates are not checked

@IraSoro IraSoro merged commit e3f9576 into master Nov 13, 2023
2 checks passed
@IraSoro IraSoro deleted the 155-bug-editing-current-period branch November 13, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Editinig current period
2 participants