Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a calendar for editing #179

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Add a calendar for editing #179

merged 6 commits into from
Nov 14, 2023

Conversation

IraSoro
Copy link
Owner

@IraSoro IraSoro commented Nov 13, 2023

Closed #170

I made two calendars: for editing and for displaying basic information.
View calendar:
image

Edit calendar:
image

@IraSoro IraSoro added this to the v2.3.5 milestone Nov 13, 2023
@IraSoro IraSoro self-assigned this Nov 13, 2023
imblowfish
imblowfish requested changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@imblowfish imblowfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also use another color scheme or borders to make it more intuitive and visible for user that this is calendar in the edit mode? Now only cancel/save buttons show that

src/pages/TabHome.tsx Show resolved Hide resolved
src/pages/TabHome.tsx Show resolved Hide resolved
src/pages/TabHome.tsx Show resolved Hide resolved
@IraSoro
Copy link
Owner Author

IraSoro commented Nov 14, 2023 •
edited
Loading

I changed the calendar styles a little to make them different:
View calendar:
image
Edit calendar:
image

imblowfish
imblowfish previously approved these changes Nov 14, 2023
View reviewed changes
@IraSoro
Copy link
Owner Author

IraSoro commented Nov 14, 2023

New edit calendar style
image

@IraSoro IraSoro merged commit 6230020 into master Nov 14, 2023
2 checks passed
@IraSoro IraSoro deleted the 170-separate-calendar-for-editing branch November 14, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imblowfish imblowfish imblowfish approved these changes

Assignees

@IraSoro IraSoro

Labels
None yet
Projects
peri
Status: Done
Milestone
v2.3.5
Development

Successfully merging this pull request may close these issues.

Make a separate calendar for editing
2 participants
@IraSoro @imblowfish