Dark theme #212
Merged
Dark theme #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imblowfish
requested changes
Jan 4, 2024
src/state/Context.tsx
Outdated
| @@ -11,4 +11,15 @@ const cyclesInit: CyclesContextI = { | |||
| updateCycles: (_newCycles) => {}, | |||
| }; | |||
|
|
|||
| interface ThemeContextI { | |||
There was a problem hiding this comment.
Usually interface name started with I, not ended
src/modals/Menu.tsx
Outdated
| const { theme, updateTheme } = useContext(ThemeContext); | ||
|
|
||
| const themesList = []; | ||
| for (const item of ["basic", "dark"]) { |
There was a problem hiding this comment.
Call this theme dark(beta), because we have some problems with it for now
imblowfish
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #51
I added a dark theme. To do this, I rewrote the code a little to make it easier to continue adding new themes. It looks like this:
But I have a problem now. If the user has selected a dark theme and opens the application, then a highlight occurs, where the default theme (light) is first shown, then the dark one. I tried to fix this using
useLayoutEffect, but it didn't work.Also, I couldn’t adapt the
ionSelectorto the dark theme (I couldn’t change the background)