Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Finnish translation and improved (slightly) Contributing instructions #304

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

minna-xD
Copy link
Contributor

@minna-xD minna-xD commented Oct 6, 2024

Happy Hacktoberfest! 🎃

I added the Finnish translation (addressing issue #279) in translations/fi.ts and updated datetime.ts and translation.ts files as instructed. Ran formatter and linter as instructed, too.

I made a small addition to the Contributing instructions because I noticed myself almost overlooking the detail. I hope you find it useful!

imblowfish
imblowfish previously approved these changes Oct 7, 2024
@IraSoro IraSoro added this to the vNext milestone Oct 7, 2024
@IraSoro IraSoro linked an issue Oct 7, 2024 that may be closed by this pull request
@IraSoro
Copy link
Owner

IraSoro commented Oct 7, 2024

Hello, @minna-xD! Thank you for your interest in the project!

Thank you for adding the Finnish language and correcting the CONTRIBUTING.md file! We will review your PR soon.

IraSoro
IraSoro previously approved these changes Oct 9, 2024
@IraSoro IraSoro dismissed stale reviews from imblowfish and themself via 101702f October 9, 2024 07:23
@IraSoro IraSoro merged commit 2f42dbf into IraSoro:master Oct 9, 2024
1 check passed
@IraSoro
Copy link
Owner

IraSoro commented Oct 9, 2024

@minna-xD, thank you and congratulations on your first contribution to the Peri project!

And Happy Hacktoberfest!

@minna-xD minna-xD deleted the finnish-translation branch October 9, 2024 20:34
@minna-xD
Copy link
Contributor Author

minna-xD commented Oct 9, 2024

You're welcome! It was an interesting translation task that made me do a bit of researching on the topic :) (I deleted the branch here, I hope that's alright! Github told me it would be safe to do so and I thought it would do it in my fork, whoops!)

@IraSoro
Copy link
Owner

IraSoro commented Oct 13, 2024

You're welcome! It was an interesting translation task that made me do a bit of researching on the topic :) (I deleted the branch here, I hope that's alright! Github told me it would be safe to do so and I thought it would do it in my fork, whoops!)

I'm glad you find this topic interesting! And it's okay that you deleted the branch.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Hacktoberfest: Add translation
3 participants