Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster PR, almost total rebuild #79

Merged
merged 29 commits into from
Nov 8, 2020
Merged

Monster PR, almost total rebuild #79

merged 29 commits into from
Nov 8, 2020

Conversation

Irev-Dev
Copy link
Owner

@Irev-Dev Irev-Dev commented Nov 8, 2020

I kept a couple of the basic components I had made, but pretty much tore it all down and started again. I was initially mostly experimenting with redwoodjs, but now that I've got somewhat of a grasp on it I rebuilt the db schema again and put it on a more healthy path. It now looks somewhat like an app.

Kurt Hutten and others added 29 commits October 30, 2020 17:21
Enforce data integrity basically, important since they're used for urls
I could do url encoding, but the idea is the the url looks good so
its helping keep the feel of the website
Enforce userName and title can only containing aphlanumeric and dashes
Allow for new parts to be created
@Irev-Dev Irev-Dev requested a review from Yash-R November 8, 2020 07:43
@Irev-Dev Irev-Dev self-assigned this Nov 8, 2020
@Irev-Dev
Copy link
Owner Author

Irev-Dev commented Nov 8, 2020

I need to decomission the heroku db for a bit for these changes to take effect.

@Irev-Dev
Copy link
Owner Author

Irev-Dev commented Nov 8, 2020

Going to merge hope for the best with the deployment 🤞 .
I'm expecting there to be problems.

@Irev-Dev Irev-Dev merged commit 69c6e39 into main Nov 8, 2020
@Yash-R
Copy link
Collaborator

Yash-R commented Nov 8, 2020

is there any issues ??@Irev-Dev

This was referenced Nov 8, 2020
@Irev-Dev
Copy link
Owner Author

Irev-Dev commented Nov 8, 2020

Hey @Yash-R
It went pretty well! 🙌.
Because I needed to re-init the database for this I was expecting issues with the deployment itself, but that all worked without a hiccup. There is still plenty of small problems and plenty of things still needed todo that I knew of and a couple of new bugs I noticed, (like I noticed the "new" button is broken 🤦 ). But yeah overall I'm happy with how this went.

I assigned this one to you just to keep you in the loop because there was a lot I had been working on in isolation to get things on a good path. Previously the database schema was very preliminary and really wasn't usable. So if you want to help some more you'll have to re-init your local db, which I can walk you through, (though it would probably be a good idea for me to put more db related steps into the read-me).

I put up a project board in an attempt to make it clear what I think should be worked on, only got three things on there atm.
https://github.com/Irev-Dev/cadhub/projects/1
But yeah wanted to ask you if you still keen to work on things? and if so what are you interested in doing, I'm guessing frontend work? there is backend work todo and as well as integration related stuff. Just trying to get a bit more context because I might be able to put up good issues for you to tackle if you'd like.
Though if you have any idea of your own, let talk about it 😄 .

@Yash-R
Copy link
Collaborator

Yash-R commented Nov 9, 2020

yes, i'm very interested to work, I would love to solve any kind off issues frontend or backend any !. And yeah new update is looking cool its a lot of hard work.

Waiting for the issues @Irev-Dev

@Irev-Dev
Copy link
Owner Author

Irev-Dev commented Nov 9, 2020

Sweet, I've assigned you to #81 and let a comment. take a look.

@Irev-Dev Irev-Dev deleted the dev branch November 9, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants