Actually push everywhere, build manifests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyar
approved these changes
Feb 6, 2024
Comment on lines
+256
to
+279
| subprocess.run( | ||
| [ | ||
| "docker", | ||
| "manifest", | ||
| "create", | ||
| major_manifest_name, | ||
| f"{gcr_image}-arm64", | ||
| f"{gcr_image}-amd64", | ||
| ] | ||
| ) | ||
| subprocess.run( | ||
| [ | ||
| "docker", | ||
| "manifest", | ||
| "create", | ||
| minor_manifest_name, | ||
| f"{gcr_image}-arm64", | ||
| f"{gcr_image}-amd64", | ||
| ] | ||
| ) | ||
| # the more specific annotation of the first manifest seems to carry through to the others | ||
| subprocess.run(["docker", "manifest", "push", gcr_image]) | ||
| subprocess.run(["docker", "manifest", "push", major_manifest_name]) | ||
| subprocess.run(["docker", "manifest", "push", minor_manifest_name]) |
There was a problem hiding this comment.
Do you need to check the returncode on these subprocesses?
There was a problem hiding this comment.
"need" is a bit of a loaded term. No, since it's the last thing it'll try to do and the output will be in the same place I'd put it if it were to fail.
Co-authored-by: Chris Jones <chris.jones@ironcorelabs.com>
BobWall23
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
I ran this and confirmed local changes up to the point I could. I did run equivalent steps for a single manifest to do some testing of that process. Haven't run a full testing that actually pushes yet.