Separate FloatOps.Generated from IntOps.Generated #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slozier
reviewed
Mar 21, 2022
| @@ -164,7 +168,7 @@ def gen_unaryops(cw, ty): | |||
| cw.write(identity_method, method_name="Abs") | |||
| cw.write(unsigned_negate_or_invert, method_name="OnesComplement") | |||
|
|
|||
| if (ty.type is not complex) and (ty.type is not bigint): | |||
| if ty.name not in ['BigInteger', 'Complex']: | |||
There was a problem hiding this comment.
No, and such checks are done in more places than here. I assume at some time this script was used to generate code for BigInteger and Complex too. I was hesitating removing those checks in case code generation for those types comes back (?), but am ready to remove them if you green-light it.
In any case, I plan another pass though this script to modernize the code it generates (separate PR).
There was a problem hiding this comment.
Feel free to yank any dead code. If I had more time on my hands I'd probably look into trying to use C# Source Generators instead of this. 😃
slozier
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #1329 (issue #52).