Feature/persisted size. Closes #193 #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test for & working implementation of collection.persistedSize()
- test for & working implementation of DB.persistedSize() - phantomjs issue to resolve
- test for & working implementation of DB.persistedSize() - JSDoc for all .persistedSize() in Persist.js
…ure/persistedSize # Conflicts: # js/lib/Persist.js # js/unitTests/tests/testsPersist.js
- lie as Promise polyfill in source.html + minified.html
- JSDoc: typdef for callback - refactored Persist.persistedSize to also return sizes of individual collections (in addition to total) - addtl test: - test for non-persisted DB|coll returning 0 - test for compressed persisted String
- small fix in test: drop db also from persistence
- complete commit for valid pull request
|
not such a good idea to leave out package.json et al from the build - have included it, new commit, now mr travis seems fine |
|
Looks great. Thanks for your hard work to put this together. Sorry it took me a bit of time to review the PR. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first version.
Main thingies:
-- reused localforage's Promise approach internally
-- stuck to callback-design of implementation
-- generating random collection + DB sizes at runtime, then validating their persisted variants
-- treat not persisted coll|DB as "0"
-- evaluate all persisted collections of a DB, no matter whether they're all attached at runtime
-- validate compressed persisted string being smaller than it's runtime uncompressed version
-- package.json (NOT COMMITTED, see below)
-- Unit Test html's: source.html + minified.html (via link href)
-- Persist.js (via require)
I have not committed the build-time files such as package.json with version increments and the various fdb*.js in /js/dist - should I at some point? Before merging pull request (eventually)?