Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: ECO Classification is a move behind #92

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fixed: ECO Classification is a move behind #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/database/gamex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1719,15 +1719,20 @@ QString GameX::ecoClassify() const
}
g.m_moves.moveToEnd();

//search backwards for the first eco position
while(g.m_moves.backward())
// Because we now only move backward() after the loop, we must ensure there are some moves
if (g.m_moves.countMoves() == 0) {
return QString();
}

// Search backwards for the first eco position
do
{
QString eco;
if (EcoPositions::isEcoPosition(g.board(),eco))
{
return eco;
}
}
} while(g.m_moves.backward());

return QString();
}
Expand Down