Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs-build.md #1735

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Update docs-build.md #1735

merged 2 commits into from
Dec 15, 2020

Conversation

manez
Copy link
Member

@manez manez commented Dec 8, 2020

Purpose / why

Adds a link to a video version of some of these instructions. This just covers the build and deploy bits. It would probably be helpful to have a video covering the installation section as well, but I don't currently have access to a fresh machine to re-install and record. If anyone out there wants to screen record themselves installing mkdocs following our instructions, I'd be happy to turn it into another Quick Lesson.

What changes were made?

New admonition pointing out to the video link.

Verification

Get meta and follow the instructions on this page to build the new version and make sure the admonition looks right 😄

Interested Parties

@Islandora/documentation


Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@rosiel
Copy link
Member

rosiel commented Dec 15, 2020

Hi @manez can you update the "last updated" date? (it's in the checklist)

@manez
Copy link
Member Author

manez commented Dec 15, 2020

Of course! I keep missing that one...

@rosiel rosiel merged commit 9989705 into main Dec 15, 2020
@rosiel rosiel deleted the manez-new-video-link branch December 15, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants