-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version files #793
Version files #793
Conversation
Works as expected. When I go to the Fedora URL with Then when I One thing that is somewhat confusing in the Fedora HTML UI is that if you click on the link, you get redirected to the HTML page for the binary resource, where, if you click on "Download Content", you get the latest version, not the one you expect. But, that should probably be expected since the Fedora HTML UI says under "Versioning", "Versioning of binary resources is not currently available through the HTML UI." @elizoller if you remove the debugging code, I can merge. Nice work, binary versioning in Fedora FTW! |
But also, Travis says Drupal\Tests\islandora\Kernel\JwtEventSubscriberTest is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To go along with the ones @mjordan found, I found 2 more. Some of them could remain at the debug
level, but should have the wording cleaned up to be more useful.
i believe Islandora-Devops/islandora-playbook#184 would need to be merged in order for travis to be happy about the new dependency. |
@elizoller I'll try to get to Islandora-Devops/islandora-playbook#184 this evening, then try a build. |
… they now make another fedora call
@mjordan travis is happy! |
I'm good with how the code looks, but I haven't tested this yet. So I'll see if I have the cycles available unless @mjordan does. |
Retesting now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected.
GitHub Issue: (Islandora/documentation#740)
What does this Pull Request do?
Connects the replacement of a Fedora flysystem file in Drupal to the versioning of an existing resource in Fedora.
What's new?
How should this be tested?
composer require drupal/file_replace
anddrush pm-enable file_replace
(or use this PR: add file_replace module to provide an interface for replacing files Islandora-Devops/islandora-playbook#184)/admin/content/files/replace/{{fid}}
http://localhost:8080/fcrepo/rest/2020-08/Barton_CHANS_2010.pdf
curl -v http://localhost:8080/fcrepo/rest/2020-08/Barton_CHANS_2010.pdf/fcr:versions
Additional Notes:
I'll need to package up a PR to islandora-playbook to add this module if people are ok with it
Interested parties
@Islandora/8-x-committers