Require Islandora using its drupal namespace. #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Solves the duplicate namespace problem encountered when Islandora Starter Site requires drupal/islandora but this repo requires islandora/islandora
Related GitHub Issue: n/a
Other Relevant Links: Add Mirador display for Paged Content. Islandora-Devops/islandora-starter-site#113
What's new?
Changes namespace of required islandora module from islandora to drupal.
How should this be tested?
Load the Starter site. Use
composer show
to see that you have bothislandora/islandora_mirador
anddrupal/islandora_mirador
competing to write code to the same folder.When requiring this version of Mirador, you should no longer have islandora/islandora but instead only drupal/islandora.
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag @alxp