Validations and specs #3
Conversation
There was a problem hiding this comment.
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✅ Added all the validations needed for the models
✅ Added unit tests for validations and methods
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| def post_counter_update | ||
| author.increment!(:posts_counter) | ||
| end | ||
|
|
||
| def most_recent_comments | ||
| comments.order(created_at: :desc).limit(5) | ||
| end |
There was a problem hiding this comment.
- Kindly consider adding unit tests for these two methods just like you have added unit test for most_recent_posts in the user_spec because as in the requirements, you need to add specs for every method and validation in the models.
There was a problem hiding this comment.
Great work adding the tests but some are failing
There was a problem hiding this comment.
Hi @IsmailChangezi,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Required Changes ♻️
Check the comments under the review.
- It will be great to ensure that all of your tests pass. It seems some are failing. Kindly check below ⬇️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread or tag me @peterrobert if something is not 100% clear.
As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Hi @IsmailChangezi,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights 💯
- No linters errors ✔️
- Descriptive pull request ✔️
- Descriptive commit messages ✔️
Optional suggestions
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Description