ISY-538: Behebung von Security Issues in isyfact-standards/release/2.x #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huy-tran-msg
force-pushed
the
feature/ISY-538-Behebung_von_Security_Issues
branch
3 times, most recently
from
7462464
to
9e5e93a
Compare
BerghoffP
added
the
medium
huy-tran-msg
force-pushed
the
feature/ISY-538-Behebung_von_Security_Issues
branch
from
9e5e93a
to
2cad8e5
Compare
|
FabianPerl
reviewed
Jul 26, 2024
| @@ -44,7 +47,7 @@ | |||
| * | |||
| */ | |||
| public class BatchProtokollTester { | |||
|
|
|||
| Logger logger = LoggerFactory.getLogger(BatchProtokollTester.class); | |||
There was a problem hiding this comment.
Gibt es einen technischen Grund warum hier nicht isy-logging eingesetzt wird?
| * Neuer Wert für xpath | ||
| */ | ||
| public void setXpath(XPath xpath) { | ||
| this.xpath = xpath; |
There was a problem hiding this comment.
Durch das Entfernen der zwei public-Methoden in der HelperKlasse BatchProtokollTester kommt es zu einem Breaking Change in etwaigen Anwendungen/Querschnittsanwendungen (auch wenn die Standards davon nicht betroffen sind)!
FabianPerl
reviewed
Jul 26, 2024
FabianPerl
reviewed
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 3 securities issues suggested by Sonarcloud by: