MessageSourceHolder: fix bug #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Die gelöschte Methode `getMessage` hat einen Bug, sie übergibt ein das gleiche wie `new String[] { null }`. Gewollt wird sein, `(String[]) null oder `new String[] {}`.
Insgesamt ist die ganze Methode redundant, weil die gleiche Signatur schon von `public static String getMessage(String schluessel, String... parameter)` abgedeckt ist.
|
In unserer Anwendung wird deshalb an 100 Stellen manuell @vonLogaJ zur Info. |
NaridaL
commented
Sep 26, 2019
| * @return die Nachricht | ||
| */ | ||
| public static String getMessage(String schluessel) { | ||
| return getMessage(schluessel, Locale.GERMANY, (String) null); |
|
Wurde mittlerweile durch IFS-568 gefixt. Siehe commit: |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Die gelöschte Methode
getMessagehat einen Bug, sie übergibt ein das gleiche wienew String[] { null }. Gewollt wird sein,(String[]) nullodernew String[] {}.Insgesamt ist die ganze Methode redundant, weil die gleiche Signatur schon von
public static String getMessage(String schluessel, String... parameter)abgedeckt ist.