Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified logo size, removed named arguments from cache_key, cache_pee… #77

Conversation

mateuszfilipek2000
Copy link
Collaborator

…k, added cached getters

CacheKey and CachePeek annotations do not have named arguments now:
removed_named_arguments

Changed logo size in readme:
changed_logo_size

Getters can be cached now:
added_cached_getters
generated_code

@mateuszfilipek2000 mateuszfilipek2000 force-pushed the fix/add_cached_getter_remove_unnecessary_named_args branch from e3c4608 to cde67aa Compare November 14, 2022 19:09
@mateuszfilipek2000 mateuszfilipek2000 marked this pull request as draft November 14, 2022 19:10
@mateuszfilipek2000 mateuszfilipek2000 force-pushed the fix/add_cached_getter_remove_unnecessary_named_args branch from cde67aa to 33273c1 Compare November 15, 2022 06:42
@mateuszfilipek2000 mateuszfilipek2000 marked this pull request as ready for review November 15, 2022 06:43
@mateuszfilipek2000 mateuszfilipek2000 force-pushed the fix/add_cached_getter_remove_unnecessary_named_args branch from 33273c1 to 834362d Compare November 15, 2022 07:01
Copy link
Contributor

@Axot017 Axot017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RSC-88
Copy link
Member

RSC-88 commented Nov 15, 2022

LPG

@mateuszfilipek2000 mateuszfilipek2000 force-pushed the fix/add_cached_getter_remove_unnecessary_named_args branch from 834362d to fc30514 Compare November 16, 2022 19:14
@Axot017 Axot017 merged commit 1542b07 into Iteo:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants