Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-7646] update processing logic for diff merge messages #714

Merged
merged 17 commits into from
Apr 29, 2024

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Mar 18, 2024

🔹 Jira Ticket(s) if any

✏️ Description

This pull request updates get messages call and the manager logic for diff messages update from the BE.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 61.67%. Comparing base (6284d55) to head (db5760a).
Report is 8 commits behind head on master.

❗ Current head db5760a differs from pull request most recent head bfbdac1. Consider uploading reports for the commit bfbdac1 to get more accurate results

Files Patch % Lines
...va/com/iterable/iterableapi/IterableApiClient.java 51.85% 10 Missing and 3 partials ⚠️
...ain/java/com/iterable/iterableapi/IterableApi.java 0.00% 8 Missing ⚠️
...om/iterable/iterableapi/IterableEmbeddedManager.kt 84.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
+ Coverage   61.41%   61.67%   +0.26%     
==========================================
  Files          75       75              
  Lines        4701     4718      +17     
  Branches      535      544       +9     
==========================================
+ Hits         2887     2910      +23     
+ Misses       1511     1503       -8     
- Partials      303      305       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

@evantk91 evantk91 requested a review from Ayyanchira April 2, 2024 20:54
@evantk91 evantk91 changed the base branch from master to evan/feature/diff-merge April 29, 2024 19:20
@evantk91 evantk91 merged commit 1a75003 into evan/feature/diff-merge Apr 29, 2024
5 checks passed
@evantk91 evantk91 deleted the evan/MOB-7646-diff-merge-messages branch April 29, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants