-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOB-8517] - Part 1 JWT #733
Conversation
1. Provide a method to stop JWT retries (regardless of retry policy) 2. Make it possible to specify a retry policy (on IterableConfig)
* JWT improvements 1. Provide a method to stop JWT retries (regardless of retry policy) 2. Make it possible to specify a retry policy (on IterableConfig) * removed sample app changes * sample app revert * sample app revert * updates * Update IterableConfig.java * Update IterableRequestTask.java
merge fixes
This will allow Iterable tester apps to read values from auth Manager for testing purpose
JWT improvements Part 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment.
} catch (Exception e) { | ||
IterableLogger.e(TAG, "timer exception: " + timer, e); | ||
} | ||
} | ||
|
||
private String getEmailOrUserId() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be used in Part 2. So will keep it to avoid the cycle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ran with the appropriate branch.
🔹 Jira Ticket(s) if any
✏️ Description