Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-8517] - Part 1 JWT #733

Merged
merged 31 commits into from
May 14, 2024
Merged

[MOB-8517] - Part 1 JWT #733

merged 31 commits into from
May 14, 2024

Conversation

Ayyanchira
Copy link
Member

@Ayyanchira Ayyanchira commented May 13, 2024

🔹 Jira Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

hardikmashru and others added 30 commits April 3, 2024 19:04
1. Provide a method to stop JWT retries (regardless of retry policy)
2. Make it possible to specify a retry policy (on IterableConfig)
* JWT improvements

1. Provide a method to stop JWT retries (regardless of retry policy)
2. Make it possible to specify a retry policy (on IterableConfig)

* removed sample app changes

* sample app revert

* sample app revert

* updates

* Update IterableConfig.java

* Update IterableRequestTask.java
This will allow Iterable tester apps to read values from auth Manager for testing purpose
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

} catch (Exception e) {
IterableLogger.e(TAG, "timer exception: " + timer, e);
}
}

private String getEmailOrUserId() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is not used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be used in Part 2. So will keep it to avoid the cycle

@Ayyanchira Ayyanchira requested a review from evantk91 May 13, 2024 23:35
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran with the appropriate branch.

@Ayyanchira Ayyanchira merged commit fbfc6fb into master May 14, 2024
4 of 5 checks passed
@Ayyanchira Ayyanchira deleted the feature/JWTImprovement branch May 14, 2024 00:25
@Ayyanchira Ayyanchira restored the feature/JWTImprovement branch May 14, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IterableAuthManager.decodedExpiration(): infinite retry loop caused by an ArrayIndexOutOfBoundsException
3 participants