[MOB-8649]: New SDK configuration options: isEuIterableService, dangerouslyAllowJsPopupsSDK #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It feels a little odd to set config values at runtime in the initialize code, would it make any sense to set the config with the process env variables instead or even move the env config values into a dedicated config library? |
ts-nguyen
approved these changes
May 23, 2024
pauljung14
reviewed
May 23, 2024
ts-nguyen
approved these changes
May 23, 2024
pauljung14
approved these changes
May 23, 2024
bradumbaugh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket(s) if any
Description
To remove complications here, we are moving these values to our config object.
Test Steps