Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #26 & should fix #31 #32

Closed
wants to merge 6 commits into from
Closed

Fix #26 & should fix #31 #32

wants to merge 6 commits into from

Conversation

xxAROX
Copy link

@xxAROX xxAROX commented Apr 11, 2023

Changes:

  • The player's session will be removed on quit, so when he/she rejoin it will fetch roles again from db.

@IvanCraft623
Copy link
Owner

Thanks for the PR, however this solution will not be sufficient, the best alternative would be to reload the session data when the player re-logs in.

Your solution is to remove the session when the player exits the server, which will partially solve the problem, but if you load the data when the player is offline (for example using the /ranks userinfo command), the issue will still occur.

@xxAROX
Copy link
Author

xxAROX commented Apr 12, 2023

I fix it when I'm home, the function to reload session is Session->loadUserData() right?

@xxAROX
Copy link
Author

xxAROX commented Apr 12, 2023

Btw great job with this plugin 👍😁

Removed quit event
Added contains function to check if session is already in there
made loadUserData public for EventListener access them
@xxAROX xxAROX changed the title Fix #26 Fix #26 & and shound fix #31 Apr 13, 2023
@xxAROX xxAROX changed the title Fix #26 & and shound fix #31 Fix #26 & and should fix #31 Apr 13, 2023
@xxAROX xxAROX changed the title Fix #26 & and should fix #31 Fix #26 & should fix #31 Apr 13, 2023
@xxAROX
Copy link
Author

xxAROX commented Apr 13, 2023

@IvanCraft623 is this acceptable?

@xxAROX
Copy link
Author

xxAROX commented Apr 13, 2023

never mind this dosn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants