Avoid null payload in mutation

Fixes graphql#192
IvanGoncharov · Jun 25, 2020 · 2a92bd9 · 2a92bd9
1 parent 74f57c9
commit 2a92bd9
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 4 deletions.
diff --git a/src/mutation/__tests__/mutation.js b/src/mutation/__tests__/mutation.js
@@ -206,6 +206,26 @@ describe('mutationWithClientMutationId()', () => {
     });
   });
 
+  it('supports mutations returning null', async () => {
+    const query = `
+      mutation M {
+        simpleRootValueMutation(input: {clientMutationId: "abc"}) {
+          result
+          clientMutationId
+        }
+      }
+    `;
+
+    expect(await graphql(schema, query, null)).to.deep.equal({
+      data: {
+        simpleRootValueMutation: {
+          result: null,
+          clientMutationId: 'abc',
+        },
+      },
+    });
+  });
+
   describe('introspection', () => {
     it('contains correct input', async () => {
       const query = `

diff --git a/src/mutation/mutation.js b/src/mutation/mutation.js
@@ -98,10 +98,10 @@ export function mutationWithClientMutationId(
     },
     resolve: (_, { input }, context, info) =>
       Promise.resolve(mutateAndGetPayload(input, context, info)).then(
-        (payload) => {
-          payload.clientMutationId = input.clientMutationId;
-          return payload;
-        },
+        (payload) => ({
+          ...payload,
+          clientMutationId: input.clientMutationId,
+        }),
       ),
   };
 }