Compatibility with 20220411.0 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors from `assembly_type` kwarg
Compatibility fixes with latest Firedrake/PyOP2 version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for compatibility with the current Firedrake/PyOP2 versions - see #17.
Aside from the
assembly_typekwarg, the rest of the call signature infiredrake.assemblelooks the same to me, so I think just removing the kwarg works. That fixed 6/7 of the failed tests.The other test failure (
examples/cahn-hillard.py) is related to an updated interface topar_loopin PyOP2. I don't totally understand the changes topar_loop, but seems like a simple fix is to move theuser_codeto thekernel_kwargsdict. All the tests are now passing with my configuration.