Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDN savedata transfer feature in fold menu #183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yanghuan95
Copy link

Hi,

I add a feature in fold menu, it's called LDN SAVE DATA TRANSFER.

With this feature, we can transfer savedata easily between your switch even if you have none WIFI.
If you have a switch and switch lite.

For mine, I always play game in switch lite when I in outside(It's so lite). But when I in home, I'd like to play in my monitor.

Even if there a feature that I can download/upload savedata to GD, I'd like this without WIFI need.

@J-D-K
Copy link
Owner

J-D-K commented Mar 25, 2023

I'm going to need to take a really close look at this when I have time before I merge. I also have no way of testing this myself because my second switch is staying as clean as it can be.

@yanghuan95
Copy link
Author

I'm going to need to take a really close look at this when I have time before I merge.
OK, my code may not clean enough.
I also have no way of testing this myself because my second switch is staying as clean as it can be.
I know that this feature may a little guys need. But it's helpful for this.

THX

@Inclsevd
Copy link

Hi there,

I just wanted to tell you that I tested this between two consoles, one of them without internet access. They found each other quickly and it worked great. Really nice feature! Thanks for this.

Currently I see that selecting the LDN option will send the latest save and it will be immediately restored on the other console, I can see the advantage of this and I would keep it as an option because if you swap saves between two consoles on a daily basis you would want it to be nice and fast. I think there are two things that would be good as options though:

  1. Add the ability to be able to select which save file to send. For example, the ability to select the save then select "send via LDN", maybe its own hotkey?
  2. Add the ability to turn "immediate LDN save restore" on or off in JKSV settings, in case the person with the receiving console doesn't want the save to be overwritten immediately. They can then restore it manually from the usual menu when they are ready.

The English translation in the UI needs to be corrected but someone else can do that easily of course.

@yanghuan95
Copy link
Author

Add the ability to be able to select which save file to send. For example, the ability to select the save then select "send via LDN", maybe its own hotkey?

So, for this, need to for all save(zip/fold/LDN just) to have a hotkey to send via LDN? If so, it's reasonable. May somebody need this to transfer old/modified savedata. So, we should select a hotkey to do this, maybe R3/ZL or other.

Add the ability to turn "immediate LDN save restore" on or off in JKSV settings, in case the person with the receiving console doesn't want the save to be overwritten immediately. They can then restore it manually from the usual menu when they are ready.

Yes, it's right, maybe I just want to transfor savedata to other. Cover it as default just used when I need daliy transfer. A optional for this it's good.

So, I will do this when I have time.
Thanks.


What do you think about implementing webdav in JKSV? Though backup in Google Drive is greate enough, for guys who have ther own webdav server(maybe NAS), backup in it feels good.

I think curl can work for just good. But when I deal with xml in JKSV, it's always curse memory overflow.

If you intersting for this feature, you can research it.

Thanks

@Inclsevd
Copy link

Add the ability to be able to select which save file to send. For example, the ability to select the save then select "send via LDN", maybe its own hotkey?

So, for this, need to for all save(zip/fold/LDN just) to have a hotkey to send via LDN? If so, it's reasonable. May somebody need this to transfer old/modified savedata. So, we should select a hotkey to do this, maybe R3/ZL or other.

Yes, exactly what I was thinking. Of course I'm not the developer of JKSV and @J-D-K might have his own ideas of how it should be done.

Thank you again for this great feature!

@yanghuan95
Copy link
Author

Add the ability to be able to select which save file to send. For example, the ability to select the save then select "send via LDN", maybe its own hotkey?

So, for this, need to for all save(zip/fold/LDN just) to have a hotkey to send via LDN? If so, it's reasonable. May somebody need this to transfer old/modified savedata. So, we should select a hotkey to do this, maybe R3/ZL or other.

Yes, exactly what I was thinking. Of course I'm not the developer of JKSV and @J-D-K might have his own ideas of how it should be done.

Thank you again for this great feature!

HAHA, OK, enjoy yourself

@J-D-K
Copy link
Owner

J-D-K commented Jun 24, 2024

So, since I've been working on the rewrite, I think this might be more doable and cleaner now. I'm really sorry it took a while. We'll need to discuss how to implement it and everything too. I've toyed with the idea myself in the past, but never had a way to test it. Now I do since I have three switches and two are unpatched.

@Inclsevd
Copy link

So, since I've been working on the rewrite, I think this might be more doable and cleaner now. I'm really sorry it took a while. We'll need to discuss how to implement it and everything too. I've toyed with the idea myself in the past, but never had a way to test it. Now I do since I have three switches and two are unpatched.

I've used it for a long time. I think it does need some cleaning up and refinement in terms of menu implementation/options and I raised some of those points in my older comments, but the actual feature works well.

@yanghuan95
Copy link
Author

yanghuan95 commented Jul 28, 2024

So, since I've been working on the rewrite, I think this might be more doable and cleaner now. I'm really sorry it took a while. We'll need to discuss how to implement it and everything too. I've toyed with the idea myself in the past, but never had a way to test it. Now I do since I have three switches and two are unpatched.

Hi, Sorry for replying so late. In fact, when I started working myself and engaged in Linux kernel development, C++ was not the main working language. Therefore, I may not have the energy to maintain this feature anymore.
This function works well for me when I use it myself. It is more suitable for scenes without WiFi such as subway or airplanes.
So, if you find this feature useful, you can try to extract the core patch and rewrite it according to your coding style.
In addition, if you have any questions about the code, I can help answer them.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants