Chunked GPU calculation #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 89.87% 88.37% -1.49%
==========================================
Files 56 66 +10
Lines 4073 5070 +997
Branches 719 920 +201
==========================================
+ Hits 3660 4480 +820
- Misses 268 400 +132
- Partials 145 190 +45
... and 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
J08nY
requested changes
Sep 19, 2023
| def _setup1D(self, output_count: int) -> CudaCTX: | ||
| """ | ||
| Creates context for 1D GPU CUDA functions | ||
| mem_size = cuda.current_context().get_memory_info().total |
There was a problem hiding this comment.
Wondering whether this should use available memory instead of total?
| _chunk_size: Optional[int] | ||
| _stream_count: Optional[int] | ||
|
|
||
| def __init__(self, |
There was a problem hiding this comment.
Please add docstring to this method and explain the arguments a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.