-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunked GPU calculation #38
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 89.87% 88.37% -1.49%
==========================================
Files 56 66 +10
Lines 4073 5070 +997
Branches 719 920 +201
==========================================
+ Hits 3660 4480 +820
- Misses 268 400 +132
- Partials 145 190 +45
... and 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add a docstring for the GPUTracemanager class init. Everything else looks great!
def _setup1D(self, output_count: int) -> CudaCTX: | ||
""" | ||
Creates context for 1D GPU CUDA functions | ||
mem_size = cuda.current_context().get_memory_info().total |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering whether this should use available memory instead of total?
_chunk_size: Optional[int] | ||
_stream_count: Optional[int] | ||
|
||
def __init__(self, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add docstring to this method and explain the arguments a bit.
No description provided.