Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Compare with (a list of) features #124

Merged
merged 5 commits into from
Dec 1, 2019

Conversation

jpweytjens
Copy link
Contributor

A small fix for #117. A Compare object set self.features to an empty list after initialization. This is removed so self.features is correctly initialized.

The documentation mentions that a both individual features or a list of features can be added. The add method always appends, leading to nested lists. This PR extends self.features if a list is passed, and appends otherwise.

@J535D165
Copy link
Owner

J535D165 commented Dec 1, 2019

Thanks Johannes! I corrected a breaking bug and added a test (that revealed a new bug). I think this one is ready for merging.

Closes #117

Repository owner deleted a comment from codecov bot Dec 1, 2019
@codecov
Copy link

codecov bot commented Dec 1, 2019

Codecov Report

Merging #124 into master will increase coverage by 1.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage    77.7%   79.07%   +1.36%     
==========================================
  Files          34       34              
  Lines        2476     2676     +200     
  Branches      392      442      +50     
==========================================
+ Hits         1924     2116     +192     
- Misses        419      421       +2     
- Partials      133      139       +6
Impacted Files Coverage Δ
recordlinkage/base.py 80.77% <100%> (+0.15%) ⬆️
recordlinkage/classifiers.py 85.54% <0%> (+1.61%) ⬆️
recordlinkage/algorithms/nb_sklearn.py 78.74% <0%> (+11.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c856272...f1821f3. Read the comment docs.

@J535D165 J535D165 merged commit 47a0383 into J535D165:master Dec 1, 2019
@jpweytjens
Copy link
Contributor Author

Thanks for spotting the wrong order of arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants