Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibize #1

Open
ensiform opened this issue Oct 10, 2015 · 2 comments
Open

Ibize #1

ensiform opened this issue Oct 10, 2015 · 2 comments

Comments

@ensiform
Copy link
Member

Ibize and the Icarus backend with it are NOT very portable still.

There seems to be a memory leak as well specifically with the CTokenizer not being cleaned up on exit for sure.

@mrwonko
Copy link

mrwonko commented Oct 10, 2015

I'd be interested in rewriting ibize, although that's really the wrong approach.

@ensiform
Copy link
Member Author

@mrwonko

Realistically want to start by fixing the Tokenizer. It currently doesn't seem to handle memory properly. Because the main instance is created but never deleted and probably all of the sub-objects too.

https://github.com/JACoders/OpenJK/blob/master/tools/Ibize/ibize.cpp#L85
https://github.com/JACoders/OpenJK/blob/master/tools/Ibize/Tokenizer.cpp
https://github.com/JACoders/OpenJK/blob/master/tools/Ibize/tokenizer.h

Let me know if you want what I have so far, as I'm not ready to put it on the remote yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants