Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo that causes comparison to always evaluate to false. #1119

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Fix typo that causes comparison to always evaluate to false. #1119

merged 2 commits into from
Sep 2, 2022

Conversation

tobhe
Copy link
Contributor

@tobhe tobhe commented May 6, 2022

Looking at the other checks in this code I think it is safe to assume that this was meant to be 1050.

@ikopysov ikopysov mentioned this pull request May 11, 2022
Open
bartrpe
bartrpe approved these changes May 18, 2022
View reviewed changes
Copy link

@bartrpe bartrpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that out of curiosity, and it's true, it's just a typo. Literally just one number change to check :P

ensiform
ensiform approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@ensiform ensiform left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Everything else is 4 digit timer checks but this was incorrectly 5 digits.

@Razish Razish merged commit 9671dd7 into JACoders:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razish Razish Razish approved these changes

@ensiform ensiform ensiform approved these changes

@bartrpe bartrpe bartrpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobhe @Razish @ensiform @bartrpe