MP: PM_VehicleViewAngles: fix use of uninitialized variables #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't use clampMin or clampMax until they have been set, at which point setAngles is set to true. Initializing it to true defeats that.
|
Certain this won't affect the cgame<>game being in sync? Being that its a bg_pmove change. |
|
In the cases where it matters (if such cases exist in practice), they'd be out of sync anyway, because the game code would be using uninitialized stack memory for the view angles; that seems unlikely to yield consistent results. |
|
I think this change makes sense. Without the change, the client and server may have been out of sync anyway if neither |
xycaleth
added a commit
that referenced
this pull request
Aug 9, 2015
MP: PM_VehicleViewAngles: fix use of uninitialized variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't use clampMin or clampMax until they have been set,
at which point setAngles is set to true. Initializing it to true
defeats that.