Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the position of h2 in the navtitle to fit screens of different sizes #64

Closed
wants to merge 1 commit into from

Conversation

WanJIN0415
Copy link
Collaborator

No description provided.

Copy link
Member

@Jogo27 Jogo27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Now h2 is not truncated anymore. But I'm not certain whether we should keep such a big subtitle on narrow screens. Have you considered other alternatives like reducing its font size, shortening the text or even hidding it completely?

Hui proposes in #63 to increase the height of the bar. How do your modifications interact? It would certainly be easier if there was only one PR about navtitle. Maybe could you cooperate on that topic.

@@ -29,7 +29,7 @@ h1

h2
font: 400 12pt 'Livvic'
margin: 0 .5em
margin: -0.5em 0em 0em 0.5em
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are not aligned anymore. On large screens, h2 is not aligned with h1. On narrow screens, the space below h2 is much shorter than the space above h2, which is itself much shorter than the interline space.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reduce the size of h2, "Polls" and "Create"? So that h2 can be displayed on a ligne in all sizes of screens and aligned downward with h1.
The code and results are as follows :
code_navtitle
navtitle
navtitle2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the size of Polls and Create independently of the width of the screen is not possible, because we want that size to be at least the size of normal text, and we don't want the size of normal text to be less than 13pt on large screen (it has been discussed with Umberto some month ago). Changing the size of all fonts depending on the width of the screen is possible though.

@WanJIN0415 WanJIN0415 closed this May 25, 2021
@WanJIN0415 WanJIN0415 deleted the jw_navtitle branch May 25, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants