Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fftw and netlib-lapack as passive dependencies for jedi-neptune-env #391

Conversation

climbfuji
Copy link
Collaborator

Description

This PR adds fftw and netlib-lapack to jedi-neptune-env. jedi-neptune-env itself doesn't depend on it for building, but they need to be there for other reasons. I found a nice workaround, namely make them build-time dependencies instead of run-time dependencies. This way, the packages get installed and the modules are created, but loading jedi-neptune-env will not load fftw and netlib-lapack automatically.

I tested this on my macOS based on the latest develop code, and also on Nautilus for spack-stack-1.6.0.

Issue(s) addressed

Working towards JCSDA/spack-stack#941

Dependencies

n/a

Impact

n/a

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

…into feature/add_fftw_lapack_jedi_neptune_env_passive
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me. Based on the description, would it make sense to have a "miscellaneous" metapackage for things like this or madis that don't really have any other home?

@climbfuji
Copy link
Collaborator Author

This is fine with me. Based on the description, would it make sense to have a "miscellaneous" meta-package for things like this or madis that don't really have any other home?

That's something we could explore, maybe with a slightly different name that indicates that we are going to suppress the module creation for that meta-package?

@climbfuji climbfuji merged commit 5cfbf8f into JCSDA:jcsda_emc_spack_stack Jan 16, 2024
15 checks passed
@climbfuji climbfuji deleted the feature/add_fftw_lapack_jedi_neptune_env_passive branch January 16, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants