Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use case-preserving packageName_ROOT env variables in auto-generated modules #421

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 10, 2024

Description

Use case-preserving packageName_ROOT env variables in auto-generated modules instead of all uppercase PACKAGENAME_ROOT.

See JCSDA/spack-stack#1068 for a list of systems that need to get updated for spack-stack-1.7.0.

Issue(s) addressed

Resolves JCSDA/spack-stack#1066

Related spack develop issue: spack#43569

Dependencies

n/a

Impact

Fixes cmake warnings and build errors.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

…modules instead of all uppercase PACKAGENAME_ROOT
@climbfuji climbfuji self-assigned this Apr 10, 2024
@climbfuji climbfuji added INFRA JEDI Infrastructure NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center labels Apr 10, 2024
@climbfuji climbfuji marked this pull request as ready for review April 10, 2024 14:21
@climbfuji
Copy link
Collaborator Author

@AlexanderRichert-NOAA I am going to plow ahead here. I just discussed with the spack developers and we'll look into a more general solution for spack after their next release that will allow users to state if they want lowercase, case-preserving (which for the case of spack packages is the same as lowercase), and uppercase. We'll get this update in from spack mainline once it is ready, but for now we can revert to what we had beforehand. Please follow spack#43569 for updates on spack develop.

@climbfuji climbfuji disabled auto-merge April 10, 2024 16:28
@climbfuji climbfuji merged commit 60f4c5f into JCSDA:release/1.7.0 Apr 10, 2024
13 checks passed
@climbfuji climbfuji deleted the bugfix/case_sensitive_ROOT_env_vars_rel170 branch April 10, 2024 16:29
@AlexanderRichert-NOAA
Copy link
Collaborator

Yep sounds good to me, I agree it's not worth the pain right now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure NOAA-EMC OAR-EPIC NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants